aredn: remove duplicate file and minify #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found a duplicated file in www, only 16k, but every bit matters now. Removed the duplicate and the replaced the file with a minified version. Updated www/cgi-bin/scan to use new minified file. Tested. works fine.
ae6xe
reviewed
Aug 4, 2018
There was a problem hiding this comment.
the issue is long term maintainability. Darryl, interested in your comments -- didn't you write this? Looks like one version is the 'maintainable' copy used to generate the mini by removing unnecessary chars for run time. Is there a way to consolidate to the maintainable version, then at run time strip the unnecessary chars to send to the client browser? (Is this the reason there is a 'mini')?
|
We only need the minified version
Thanks,
Darryl
… On Aug 4, 2018, at 9:23 AM, Joe AE6XE ***@***.***> wrote:
@ae6xe commented on this pull request.
the issue is long term maintainability. Darryl, interested in your comments -- didn't you write this? Looks like one version is the 'maintainable' copy used to generate the mini by removing unnecessary chars for run time. Is there a way to consolidate to the maintainable version, then at run time strip the unnecessary chars to send to the client browser? (Is this the reason there is a 'mini')?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
ae6xe
approved these changes
Aug 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a duplicated file in www, only 16k, but every bit matters now.
Removed the duplicate and replaced the file with a minified version.
Updated www/cgi-bin/scan to use new minified file.
Tested. works fine.